Skip to content

experimental fix, remove deviceInUse check #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

experimental fix, remove deviceInUse check #1908

merged 1 commit into from
Jan 17, 2025

Conversation

leiyiz
Copy link
Contributor

@leiyiz leiyiz commented Jan 17, 2025

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

EXPERIMENTAL COMMIT, DO NOT INCLUDE IN REGULAR RELEASE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leiyiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2025
@leiyiz leiyiz requested review from pwschuurman and removed request for amacaskill and saikat-royc January 17, 2025 20:25
@pwschuurman
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

@leiyiz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e 7233438 link true /test pull-gcp-compute-persistent-disk-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@leiyiz
Copy link
Contributor Author

leiyiz commented Jan 17, 2025

the e2e test that failed is: GCE PD CSI Driver [It] Should block unstage if filesystem mounted which was added to test the logic that we removed.

@pwschuurman
Copy link
Contributor

One test failed:


Summarizing 1 Failure:
  [FAIL] GCE PD CSI Driver [It] Should block unstage if filesystem mounted
  /home/prow/go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/test/e2e/tests/single_zone_e2e_test.go:1498
Ran 43 of 51 Specs in 1546.743 seconds
FAIL! -- 42 Passed | 1 Failed | 2 Pending | 6 Skipped
--- FAIL: TestE2E (1546.74s)
FAIL
FAIL	sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/test/e2e/tests	1546.769s
FAIL
+ EXIT_VALUE=1
+ set +o xtrace

This was a test that was added as a complement to #1658. Merging, as this is expected to fail, now that the DeviceInUse check is ignored.

@pwschuurman pwschuurman merged commit 17072be into kubernetes-sigs:release-1.14-experimental Jan 17, 2025
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwschuurman pwschuurman Awaiting requested review from pwschuurman

Assignees

@pwschuurman pwschuurman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leiyiz @k8s-ci-robot @pwschuurman